- Issue created by @nicxvan
- 🇨🇭Switzerland berdir Switzerland
Verified that this is a clean move with --color-moved git diff (git dm alias on https://www.md-systems.ch/en/blog/techblog/2011/08/22/git-aliases. yes, using a blog post from 2011 as a documentation page).
the only function left in common_test is the weird theme alter that has a separate issue to decide on moving or deleting it.
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- First commit to issue fork.
- 🇺🇸United States nicxvan
There is no need to merge the 11.x branch in, you can rebase, it keeps future rebases cleaner.
I think you got the instances of Preprocess.
- 🇬🇧United Kingdom catch
The library etc. hooks are more like 'html rendering' hooks than theme hooks but the hook documentation organisation predates us having a render/library/asset layer distinct from the theme system or form API.
We might want to revisit this at some point but don't feel strongly enough to block commit on moving them back or elsewhere.
Committed/pushed to 11.x, thanks!