Contrib.social

Component/Slot overlay is brittle if HTML comments are missing

Open on Drupal.org →
Created on 13 May 2025, 21 days ago

Overview

We currently parse HTML comments to find slots. But this requires every Source plugin to render its output using xb_slot_ids and xb_uuid in order for the Twig extension to output these comments.
If they don't exist but a slot exists in the component model, it causes an error in the frontend - this line in ComponentOverlay.tsx

parentElementInsideIframe = slotsMap[parentSlot.id].element;

Because there is no entry in slotsMap.

Proposed resolution

Make this code more resilient so that every source plugin doesn't have to conform to a particular twig format in order to get the HTML comments

User interface changes

🐛 Bug report
Status

Active

Version

0.0

Component

Page builder

Created by

🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024