- Issue created by @larowlan
- ๐ฎ๐ณIndia sanket.tale
sanket.tale โ made their first commit to this issueโs fork.
- Merge request !10253524047: Implement SlotOverlay to render dynamic overlays for slots within components. โ (Open) created by sanket.tale
- ๐ฎ๐ณIndia sanket.tale
Added SlotOverlay component with dynamic positioning and slot drop support.
Need help fixing the pipeline issue with image assertion in iframe during tests. - ๐ฌ๐งUnited Kingdom jessebaker
@larowlan I'm unclear what "this code" is referring to in the following:
Make this code more resilient so that every source plugin doesn't have to conform to a particular twig format in order to get the HTML comments
Do you mean make the code that inserts the HTML comments more resilient (so change that a Source plugin can render its output without using xb_slot_ids and xb_uuid but still have the Twig extension output the comments.) or are you talking about making the FE code more resilient (e.g. handle the situation where the layout/model data suggests there is a slot but the markup does not have comments)?
- ๐ฆ๐บAustralia larowlan ๐ฆ๐บ๐.au GMT+10
The code in question is
parentElementInsideIframe = slotsMap[parentSlot.id].element;
The code in the MR is what I was expecting - this only happens if you write your own Source plugin and don't emit the comments.
Its failing tests so needs work