Remove Gin Admin Theme legacy fallbacks

Created on 12 May 2025, 11 days ago

Problem/Motivation

Since https://www.drupal.org/project/gin/issues/3309113 πŸ“Œ Change CSS3 variables from camelCase to kebab-case Fixed the gin admin theme has not used the old CSS variables we use in our CSS as a fallback.

We should be able to remove legacy fallbacks in a minor release, as long as we note Gin Admin Theme compatibility.

Steps to reproduce

Currently CSS for Gin Theme looks like this:

.gin--vertical-toolbar .toolbar-menu-administration > .toolbar-menu > .menu-item .toolbar-menu {
  margin-inline-start: calc(var(--gin-toolbar-width-collapsed, var(--ginToolbarWidthCollapsed)) - 4px);
}

.gin--vertical-toolbar[data-toolbar-menu="open"] .toolbar-menu-administration > .toolbar-menu > .menu-item .toolbar-menu {
  margin-inline-start: calc(var(--gin-toolbar-width, var(--ginToolbarWidth)) - 4px);
}

These two variables do not follow current drupal coding standards.
--ginToolbarWidth
--ginToolbarWidthCollapsed

And have been replaced upstream with

--gin-toolbar-width-collapsed
--gin-toolbar-width

Proposed resolution

If we need a fallback, we should use whatever they are using in the gin admin theme.

Remaining tasks

Create a merge request.

User interface changes

API changes

Data model changes

πŸ“Œ Task
Status

Active

Version

4.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States trackleft2 Tucson, AZ πŸ‡ΊπŸ‡Έ

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024