Since https://www.drupal.org/project/gin/issues/3309113 📌 Change CSS3 variables from camelCase to kebab-case Fixed the gin admin theme has not used the old CSS variables we use in our CSS as a fallback.
We should be able to remove legacy fallbacks in a minor release, as long as we note Gin Admin Theme compatibility.
Currently CSS for Gin Theme looks like this:
.gin--vertical-toolbar .toolbar-menu-administration > .toolbar-menu > .menu-item .toolbar-menu {
margin-inline-start: calc(var(--gin-toolbar-width-collapsed, var(--ginToolbarWidthCollapsed)) - 4px);
}
.gin--vertical-toolbar[data-toolbar-menu="open"] .toolbar-menu-administration > .toolbar-menu > .menu-item .toolbar-menu {
margin-inline-start: calc(var(--gin-toolbar-width, var(--ginToolbarWidth)) - 4px);
}
These two variables do not follow current drupal coding standards.
--ginToolbarWidth
--ginToolbarWidthCollapsed
And have been replaced upstream with
--gin-toolbar-width-collapsed
--gin-toolbar-width
If we need a fallback, we should use whatever they are using in the gin admin theme.
Create a merge request.
Active
4.0
Code
trackleft2 → changed the visibility of the branch 3524015-remove-gin-admin to hidden.