As with SDC covered in š Leap ahead of #3493070 in core: SDC `enum` props should have human-readable labels: use `meta:enum` Active , enum values do not have (translatable) labels.
We need human-readable equivalents, and those equivalents must be translatable (using Drupal's interface translation mechanism).
ā ļø Out-of-scope here: translatability. Nothing in XB is translatable yet today. This will add the necessary infrastructure to make it feasible later š
JavaScriptComponent config entities), should use the same metadata structure as SDCs.
For that, see the attached config schema patch ā .
\Drupal\Tests\experience_builder\Functional\XbConfigEntityHttpApiTest::testJavaScriptComponent() to also create a enum prop. This should first fail validation (422 response), then upon adding the matching meta:enum, it should pass validation.
This is XB's equivalent for
- TEST: kernel test asserting that a
meta:enumnot matching theenumtriggers a\LogicException
\Drupal\experience_builder\JsonSchemaInterpreter\SdcPropJsonSchemaType::toDataTypeShapeRequirements() to do the equivalent of
- INFRA: add a
getEnumOptions(string $prop): array<string, TranslatableMarkup>method to\Drupal\Core\Theme\Component\ComponentMetadatainspired byui_patterns'\Drupal\ui_patterns\EnumTrait::getEnumOptions(). (The thing thatui_patternsdoes not yet do is pass it through Drupal'st().)
That means changing e.g.
SdcPropJsonSchemaType::STRING => match (TRUE) {
array_key_exists('enum', $schema) => new DataTypeShapeRequirement('Choice', [
'choices' => $schema['enum'],
], NULL),
to actually use the meta:enum values.
(Note that here, they must NOT be translated ā translation must happen at runtime ā this corresponds to a FieldConfig config entity aka configuration.)
ui/tests/e2e/prop-types.cy.js to prove that the labels for the enum indeed appear in the UI, by updating the it('Enum (select) - string', () => { test case.
This is XB's equivalent for
- TEST: kernel test asserting that 2 identical
type: string, enum: [ā¦]props can have different translations for the same enum values. For example: a''enum value results inSame windowfor thetargetprop and inNonefor arelprop.
ā verifies it works end-to-end, and supports translation contexts
enum and a matching meta:enum will now be asked for labels instead of values, and the values will be automatically generated client-side.enum and a matching meta:enum will now see those labels in the component inputs form on the right-hand side.Active
0.0
Component sources
Makes Drupal easier to use. Preferred over UX, D7UX, etc.
Wim prefers we do Js too in š Leap ahead of #3493070 in core: SDC `enum` props should have human-readable labels: use `meta:enum` Active