Contrib.social

Improve stop condition form fields

Open on Drupal.org →
Created on 9 May 2025, 7 days ago

Problem/Motivation

As i worked on Issue 3394957 🐛 The checkbox 'Enable scheduled newsletter' doesn't work when you try to disble newsletter scheduling Active I recognized, that the form fields for the stop condition of the scheduled newsletter could be improved.
- the maximum number of editions is not a number form field
- the maximum number of editions is not required (when stoptype is 2)
- the stop date is not required (when stoptype is 1)

Steps to reproduce

Go to scheduler tab of a newsletter edition which is a template and play around with the stop condition fields.

Proposed resolution

I propose ...

  1. to switch the field widget for the maximum number of editions to 'number' and set min value zu zero
  2. set a required condition for the maximum number of editions to be required when the stoptype is 2
  3. set a required condition for the stop date form field to be required when the stoptype is 1

Because of a core bug with the date time field, we might need a validate function for step 3. See

✨ Feature request
Status

Active

Version

4.0

Component

Code

Created by

🇩🇪Germany jocowood Kamp-Lintfort

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024