- Issue created by @nicxvan
- π³π±Netherlands bbrala Netherlands
Shoudlnt the parameter be typed? Its new and seems to be an ?orderinterface
- πΊπΈUnited States smustgrave
Seems straight forward, we had a brief conversation in slack about any questions haha
LGTM
- πΊπΈUnited States dww
Yeah, the original FormAlter issue was open and in progress before the order issue landed, so we forgot. Also mentioned at π Rethink #[Hook] attribute inheritance Active
Agreed this is RTBC.
Bumping prio, tagging, and adding related
- πΊπΈUnited States dww
Suggestion applied, pipeline is green again. I think we can sort out the
public
stuff at π Rethink #[Hook] attribute inheritance ActiveCrediting @donquixote for pointing out this omission (per comment #5), and MR and Slack reviews.
-
longwave β
committed 9d285494 on 11.x
Issue #3523159 by nicxvan, dww, donquixote: Add order parameter to...
-
longwave β
committed 9d285494 on 11.x
- π¬π§United Kingdom longwave UK
Committed 9d28549 and pushed to 11.x. Thanks!
I agree this could do with a bit more cleanup but let's defer that to π Rethink #[Hook] attribute inheritance Active .