- Issue created by @danrod
- @danrod opened merge request.
- 🇨🇦Canada danrod Ottawa
I used the Boostrap 3 fork as suggested and it worked as expected, I don't see the console warning anymore and the main menu on Desktop works better, so I'll delete the temporary JavaScript that I put to fix it
estore.menu.js
, but the mobile menu doesn't work well and the search dropdown is not working as well.There's some documentation that the 7pro folks put up for using this fork, we'll need through all of this:
https://bootstrap.7pro.ca/docs/3.4/javascript/#dropdowns
https://www.npmjs.com/package/entreprise7pro-bootstrapThe README.md file needs to reflect this for instructions on how to install the fork.
- 🇨🇦Canada danrod Ottawa
I'll move the ticket to "Needs Review" just in case I find other issues with this bootstrap fork, but I'll merge the current MR in order to fix the Mobile Menu and the Search Dropdown.
- 🇨🇦Canada danrod Ottawa
I think I'll mark this as "Fixed", the forked Bootsrap 3 project suits this theme's needs, but I might fork it to fix some remaining issues I see.
I'll continue making fixes in the theme and make it ready to migrate it to Bootstrap 5
- 🇨🇦Canada danrod Ottawa
Given that I received no response from the issue I created in their github's page, I decided to fork the project, include the function I needed it and compile it again, I have my own release: https://github.com/danrod96-new/bootstrap/releases/tag/v1.0.0
I re-opened this to update these files to reflect the new Bootstrap 3 fork release:
composer.libraries.json estore.libraries.yml README.md
I'll create a new MR for this.
- @danrod opened merge request.
- 🇨🇦Canada danrod Ottawa
I merged and tested the new changes and works as expected, moving this to "Fixed" again.