Problem/Motivation
Thanks for this useful module.
Here is an example of site.webmanifest
that gets generated by realfavicongenerator.net
{
"name": "FooBar",
"short_name": "FooBar",
"icons": [
{
"src": "/web-app-manifest-192x192.png",
"sizes": "192x192",
"type": "image/png",
"purpose": "maskable"
},
{
"src": "/web-app-manifest-512x512.png",
"sizes": "512x512",
"type": "image/png",
"purpose": "maskable"
}
],
"theme_color": "#ffffff",
"background_color": "#ffffff",
"display": "standalone"
}
If I understand correctly, these will be loaded using http://domain.com/web-app-manifest-192x192.png which would give a 404 since responsive_favicon does not take over those 2 routes.
Simply removing the trailing slash which makes those relative to the manifest is probably the easiest and seems to solve.
This can be confirmed in chrome devtools (Application > Manifest > Icons).
Maybe a note on this is missing in the readme.
Steps to reproduce
- Setup module as per readme
- Notice in chrome devtools (Application > Manifest > Icons) the warnings ("Icon ... failed to load")
Proposed resolution
Update the readme to add a note that the trailing slash needs to be removed?
And possibly that this can be verified/tested in chrome devtools.
Remaining tasks
TODO
User interface changes
None
API changes
None
Data model changes
None