Deprecate passing $root to \Drupal\Core\Database\Database::convertDbUrlToConnectionInfo()

Changes made

Looks good to me, tagging for change record updates as it does make sense to merge this with the other one - let's do that on commit.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

The bot is wrong.

Actually no, something has changed in PHPStan, I get the same locally

  Line   lib/Drupal/Core/Test/TestSetupTrait.php (in context of                                           
         class@anonymous/tests/Drupal/Tests/Core/Test/TestSetupTraitTest.php:39)                          
 ------ ------------------------------------------------------------------------------------------------- 
  137    Method                                                                                           
         class@anonymous/tests/Drupal/Tests/Core/Test/TestSetupTraitTest.php:39::prepareDatabasePrefix()  
         has no return type specified.                                                                    
         🪪  missingType.return                                                                           
  146    Method                                                                                           
         class@anonymous/tests/Drupal/Tests/Core/Test/TestSetupTraitTest.php:39::changeDatabasePrefix()   
         has no return type specified.                                                                    
         🪪  missingType.return         

Looks like bot and your local have an old baseline version? I added the return type and the core CI job tells me to remove the above from the baseline

https://git.drupalcode.org/issue/drupal-3522513/-/pipelines/490932

Seems phpstan is still failing.

Tests seem to be happy now

@longwave you tagged for change record updates?

Updated the previous CR to include this issue.

This isn't disruptive so can still be removed in 12.x, updated the deprecation version to 11.3

Committed/pushed to 11.x, thanks!

catch → closed merge request !12028