Contrib.social

ModuleResultForm doesn't complete LP if passed

Open on Drupal.org →
Created on 30 April 2025, 6 days ago

Problem/Motivation

When manually scoring a Learning Path, the ModuleResultForm doesn't check and update the Learning Path status. This results in an odd state in which the module(s) are complete, but not the LP.

Steps to reproduce

  1. Create a new Learning Path with a single module, and a single file upload activity
  2. Require the activity to be manually scored
  3. Have a user complete the activity
  4. Manually score the user as passed
  5. The user will show a completed Module Status, but an incomplete Learning Path status

Proposed resolution

Modify the ::submitForm() to also check if the LP has passed.

Remaining tasks

Create patch.

User interface changes

None.

API changes

None.

Data model changes

None.

🐛 Bug report
Status

Active

Version

3.2

Component

Code

Created by

🇺🇸United States socketwench

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @socketwench
  • Comment 6 days ago →
    🇺🇸United States socketwench

    This patch adds a check to complete the Learning Path in the form. This works, but as I borrowed this from OpignoModuleController::userStatus(), I feel the problem is architectural. Either way, this works to correct the fault for manual scoring.

  • Comment 4 days ago →
    🇺🇸United States socketwench

    This updated patch corrects a fault where the step achievements also do not score correctly, resulting in an issue where the opigno_statistics.training route does not display the expected completion amount.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024