Throughout Opigno, multiple modules assume that the user_module_status table stores the scores in points. This is incorrect, and values are stored as an integer percent (0-100). This creates a problem in other Opigno modules as LP steps now have no way to calculate the module's score in points for comparison with 'required score'.
Elsewhere in opigno_modules, the score in points is calculated in reference to the max score:
score_in_points = best_score * max_score / 100.
Without this, the best_score is always 0-100, and there's no way to compare it to 'required score'.
This is most often exposed when an activity or module is manually scored. Without the max_score, opigno_module compares best_score to required score, and unless the required score is exactly 100 points, the comparison will give erroneous results.
Add the max score to the output of the array. This should be used in concert with other patches which correct this problem in opigno_module:
* https://www.drupal.org/project/opigno_module/issues/3521268 🐛 getAttemptScore() calculates scores incorrectly Active
Create patch.
None.
The max score for the step will now be present in the output array.
None.
Active
3.2
Code
In addition, opigno_learning_path_get_step_status() and opigno_learning_path_is_passed() don't calculate the step's completeness correctly for this reason. By including the max score, we can calculate the correct result in these methods too.