Offering to co-maintain Commerce Invoice

Contacted now latest active maintainer via contact tab

Hi Afagioli and thanks for offering your time to maintain Commerce Invoice. However, before adding you as maintainer, I'd appreciate seeing some activity in the queue... I can be available to review patches etc if needed...

Also, you can help reviewing existing issues, providing your input, all of that can be done without being a maintainer.
I haven't seen you active in the Commerce Invoice queue afaik yet.

We usually don't blindly add maintainers to the project and we tend to do that after seeing / reviewing contributions.

Sounds good to me!

I'm pretty new in this heavy issue queue indeed.
Please suggest a criteria to move that RC forward

No need here to feel blind. You can look at me activity at https://www.drupal.org/u/afagioli →

Dear Maintainers,
as we approach the stable release of commerce invoice 8.x-2.0, would it be possible to create a META issue to recap and track all remaining critical issues that need resolution before moving from RC to stable?

This would help:

* Provide a clear checklist of must-fix blockers.
* Ensure no critical regressions are overlooked.
* Allow contributors to focus on priority tasks.

Thanks a lot

I know you have experience, I don't really doubt that, but in general we tend to add maintainers after seeing multiple contributions. And since I haven't seen you active in the queue, I can't really judge if you have experience with the Commerce eco system and also don't really know what direction you're planning to take with the module. Are you looking to commit existing patches? Implement new features? Feel free to reach out to me on Slack as well.

Dear Maintainers,
as we approach the stable release of commerce invoice 8.x-2.0, would it be possible to create a META issue to recap and track all remaining critical issues that need resolution before moving from RC to stable?

This would help:

* Provide a clear checklist of must-fix blockers.
* Ensure no critical regressions are overlooked.
* Allow contributors to focus on priority tasks.

Thanks a lot

We have no immediate plan to add new features to the module, if "rc" is the problem, I can go ahead and tag a stable release as well.

By looking at the queue it seems the main stable release blocker might be 🐛 Invoice email is sent twice RTBC and 🐛 mail attachment not included Closed: won't fix which are probably duplicates.

I reviewed 🐛 Invoice email is sent twice RTBC quickly but don't really like the direction this is taking.

"We have no immediate plan to add new features to the module, if "rc" is the problem, I can go ahead and tag a stable release as well."

Yes, please if you can :)

See my comment #9, I think these issues need to be looked at, if you'd like to give it a shot, please do :). Otherwise I can probably look into this later today or on Friday.

"Feel free to reach out to me on Slack as well."
Thanks!

Hi,

RC releases are mostly for small bug fixes, not new features—like that email double-sending thing, right?
Matter of fact, the issue in #9 is for 8.x-2.x-dev, and we're trying to push the RC forward now.

Since you know this module best, it’s your call—should we treat that as a bug (and include it in the RC) or save it as a new feature for later?
Option 2 would speed up the process of course

RC releases are mostly for small bug fixes, not new features—like that email double-sending thing, right?

I don't see how that is a new feature, this is reported as a bug, twice?
Will take a stab at it today and then tag a stable release after that (Maybe will include a couple more issues in the release).

Thanks a lot
Available to help where possible

We know have a stable release.

Super.
Thanks a lot really

If you can contribute with the documentation, help would be much appreciated.

#18 it's done
https://www.drupal.org/node/3522060 →

With such a promt action from your side, this issue can be happily closed
Thanks a lot for your efforts!