Take non-Clean URL requests into account

Created on 29 April 2025, about 1 month ago

Problem/Motivation

When the missing file is requested via a 'non-Clean URL' → e.g. /index.php/path/to/asset.jpg, it needs to:

1. Check if the file exists, skipping the need to re-download it when not necessary.
2. Stop an infinite redirect, by ensuring the redirected file path *does not* include the "script" part of the URL. See \Drupal\Core\Utility\UnroutedUrlAssembler::addOptionDefaults()

Steps to reproduce

Request the missing file via the /index.php/ prefix, it results in a loop of it redownloading the same file whether it exists or not.

Proposed resolution

Take into account whether the current request is a clean URL (\Drupal\Core\Routing\RequestHelper::isCleanUrl()) whilst processing the redirect, or always specify the default script in the routing option so the script portion is never included in the final redirect path.

Remaining tasks

Provide issue fork/patch.

📌 Task

Status

Active

Version

3.1

Component

Code

Created by

codebymikey

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @codebymikey
@codebymikey opened merge request.
Comment about 1 month ago →
codebymikey
Comment about 1 month ago →
🇺🇸United States smustgrave
Can we get a test for this change.
Comment about 1 month ago →
codebymikey
The initial /index.php tests failed because the gitlab runner runs under a subdirectory whereas my local environment didn't.

It now takes the $base_path into account when making the test requests.

The test covers a lot more test cases, also opted to use a dedicated service for the stage_file_proxy http client rather than the generic one in case the behaviour needs to be altered for whatever reason e.g. for testing or custom implementation.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024