- Issue created by @PhilY
- Merge request !11974Draft: Issue #3495165 by catch, joeyroth, berdir, texas-bronius: Better warning... → (Closed) created by PhilY
- 🇫🇷France PhilY 🇪🇺🇫🇷 Paris, France
MR !11974 is bad (my fault), will try a new one.
I'm using Drupal 11.1 and PHP 8.3.
While playing adding watermarking on an image style, I got the error
Deprecated function: round(): Passing null to parameter #1 ($num) of type int|float is deprecated in Drupal\system\Plugin\ImageToolkit\Operation\gd\Resize->validateArguments() (line 39 of core/modules/system/src/Plugin/ImageToolkit/Operation/gd/Resize.php).
In core/modules/system/src/Plugin/ImageToolkit/Operation/gd/Resize.php, it looks like
protected function validateArguments(array $arguments) {
// Assure integers for all arguments.
$arguments['width'] = (int) round($arguments['width']);
$arguments['height'] = (int) round($arguments['height']);should be relaced with
protected function validateArguments(array $arguments) {
// Assure integers for all arguments.
$arguments['width'] = round((int) $arguments['width']);
$arguments['height'] = round((int) $arguments['height']);Attached patch is a starting point.
Active
11.1 🔥
system.module
MR !11974 is bad (my fault), will try a new one.