PHP CS fixes

FILE: /var/www/html/web/modules/custom/calendar/calendar_datetime/src/Plugin/views/argument_default/Date.php -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 29 | ERROR | [x] Property \Drupal\calendar_datetime\Plugin\views\argument_default\Date::$dateFormat does not have native type hint for its value but it should be possible to add it based on @var annotation "string". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/modules/custom/calendar/src/Plugin/ViewsTemplateBuilder/ViewsFieldTemplate.php -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 27 | ERROR | [x] Property \Drupal\calendar\Plugin\ViewsTemplateBuilder\ViewsFieldTemplate::$fieldManager does not have native type hint for its value but it should be possible to add it based on @var annotation | | "\Drupal\Core\Entity\EntityFieldManagerInterface". (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/modules/custom/calendar/src/Plugin/views/argument_validator/CalendarValidator.php -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 29 | ERROR | [x] Property \Drupal\calendar\Plugin\views\argument_validator\CalendarValidator::$argumentWrapper does not have native type hint for its value but it should be possible to add it based on @var annotation | | "\Drupal\calendar\DateArgumentWrapper". (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 36 | ERROR | [x] Property \Drupal\calendar\Plugin\views\argument_validator\CalendarValidator::$dateFormatter does not have native type hint for its value but it should be possible to add it based on @var annotation | | "\Drupal\Core\Datetime\DateFormatterInterface". (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/modules/custom/calendar/src/Plugin/views/style/Calendar.php -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 5 LINES -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 52 | ERROR | [x] Property \Drupal\calendar\Plugin\views\style\Calendar::$usesFields does not have native type hint for its value but it should be possible to add it based on @var annotation "bool". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 59 | ERROR | [x] Property \Drupal\calendar\Plugin\views\style\Calendar::$usesRowPlugin does not have native type hint for its value but it should be possible to add it based on @var annotation "bool". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 66 | ERROR | [x] Property \Drupal\calendar\Plugin\views\style\Calendar::$usesGrouping does not have native type hint for its value but it should be possible to add it based on @var annotation "bool". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 112 | ERROR | [x] Property \Drupal\calendar\Plugin\views\style\Calendar::$currentDay does not have native type hint for its value but it should be possible to add it based on @var annotation "\DateTime". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 119 | ERROR | [x] Property \Drupal\calendar\Plugin\views\style\Calendar::$messenger does not have native type hint for its value but it should be possible to add it based on @var annotation "\Drupal\Core\Messenger\MessengerInterface". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/modules/custom/calendar/src/Plugin/views/pager/CalendarPager.php -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 35 | ERROR | [x] Property \Drupal\calendar\Plugin\views\pager\CalendarPager::$argument does not have native type hint for its value but it should be possible to add it based on @var annotation "\Drupal\calendar\DateArgumentWrapper". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/modules/custom/calendar/src/CalendarDateInfo.php -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 13 ERRORS AFFECTING 13 LINES -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 16 | ERROR | [x] Property \Drupal\calendar\CalendarDateInfo::$calendarType does not have native type hint for its value but it should be possible to add it based on @var annotation "string". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 24 | ERROR | [x] Property \Drupal\calendar\CalendarDateInfo::$dateArgument does not have native type hint for its value but it should be possible to add it based on @var annotation | | "\Drupal\calendar_datetime\Plugin\views\argument\Date". (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 32 | ERROR | [x] Property \Drupal\calendar\CalendarDateInfo::$dateArgumentPosition does not have native type hint for its value but it should be possible to add it based on @var annotation "int". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 40 | ERROR | [x] Property \Drupal\calendar\CalendarDateInfo::$timezone does not have native type hint for its value but it should be possible to add it based on @var annotation "\DateTimeZone". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 48 | ERROR | [x] Property \Drupal\calendar\CalendarDateInfo::$granularity does not have native type hint for its value but it should be possible to add it based on @var annotation "string". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 56 | ERROR | [x] Property \Drupal\calendar\CalendarDateInfo::$range does not have native type hint for its value but it should be possible to add it based on @var annotation "string". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 65 | ERROR | [x] Property \Drupal\calendar\CalendarDateInfo::$minDate does not have native type hint for its value but it should be possible to add it based on @var annotation "\DateTime". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 73 | ERROR | [x] Property \Drupal\calendar\CalendarDateInfo::$minYear does not have native type hint for its value but it should be possible to add it based on @var annotation "string". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 81 | ERROR | [x] Property \Drupal\calendar\CalendarDateInfo::$minMonth does not have native type hint for its value but it should be possible to add it based on @var annotation "string". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 89 | ERROR | [x] Property \Drupal\calendar\CalendarDateInfo::$minDay does not have native type hint for its value but it should be possible to add it based on @var annotation "string". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 97 | ERROR | [x] Property \Drupal\calendar\CalendarDateInfo::$minWeek does not have native type hint for its value but it should be possible to add it based on @var annotation "int". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 105 | ERROR | [x] Property \Drupal\calendar\CalendarDateInfo::$maxDate does not have native type hint for its value but it should be possible to add it based on @var annotation "\DateTime". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 114 | ERROR | [x] Property \Drupal\calendar\CalendarDateInfo::$forbid does not have native type hint for its value but it should be possible to add it based on @var annotation "bool". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/modules/custom/calendar/src/CalendarStyleInfo.php -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 15 ERRORS AFFECTING 15 LINES -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 16 | ERROR | [x] Property \Drupal\calendar\CalendarStyleInfo::$calendarPopup does not have native type hint for its value but it should be possible to add it based on @var annotation "bool". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 24 | ERROR | [x] Property \Drupal\calendar\CalendarStyleInfo::$mini does not have native type hint for its value but it should be possible to add it based on @var annotation "bool". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 32 | ERROR | [x] Property \Drupal\calendar\CalendarStyleInfo::$monthNameSize does not have native type hint for its value but it should be possible to add it based on @var annotation "int". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 40 | ERROR | [x] Property \Drupal\calendar\CalendarStyleInfo::$nameSize does not have native type hint for its value but it should be possible to add it based on @var annotation "int". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 48 | ERROR | [x] Property \Drupal\calendar\CalendarStyleInfo::$showTitle does not have native type hint for its value but it should be possible to add it based on @var annotation "bool". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 56 | ERROR | [x] Property \Drupal\calendar\CalendarStyleInfo::$showNavigation does not have native type hint for its value but it should be possible to add it based on @var annotation "bool". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 64 | ERROR | [x] Property \Drupal\calendar\CalendarStyleInfo::$showWeekNumbers does not have native type hint for its value but it should be possible to add it based on @var annotation "bool". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 71 | ERROR | [x] Property \Drupal\calendar\CalendarStyleInfo::$showEmptyTimes does not have native type hint for its value but it should be possible to add it based on @var annotation "bool". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 79 | ERROR | [x] Property \Drupal\calendar\CalendarStyleInfo::$groupByTimes does not have native type hint for its value but it should be possible to add it based on @var annotation "string". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 87 | ERROR | [x] Property \Drupal\calendar\CalendarStyleInfo::$customGroupByTimes does not have native type hint for its value but it should be possible to add it based on @var annotation "string". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 95 | ERROR | [x] Property \Drupal\calendar\CalendarStyleInfo::$customGroupByField does not have native type hint for its value but it should be possible to add it based on @var annotation "string". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 103 | ERROR | [x] Property \Drupal\calendar\CalendarStyleInfo::$maxItems does not have native type hint for its value but it should be possible to add it based on @var annotation "int". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 111 | ERROR | [x] Property \Drupal\calendar\CalendarStyleInfo::$maxItemsStyle does not have native type hint for its value but it should be possible to add it based on @var annotation "string". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 119 | ERROR | [x] Property \Drupal\calendar\CalendarStyleInfo::$themeStyle does not have native type hint for its value but it should be possible to add it based on @var annotation "int". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 127 | ERROR | [x] Property \Drupal\calendar\CalendarStyleInfo::$multiDayTheme does not have native type hint for its value but it should be possible to add it based on @var annotation "int". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 15 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/modules/custom/calendar/src/DateArgumentWrapper.php -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 17 | ERROR | [x] Property \Drupal\calendar\DateArgumentWrapper::$dateArg does not have native type hint for its value but it should be possible to add it based on @var annotation "\Drupal\views\Plugin\views\argument\Date". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 24 | ERROR | [x] Property \Drupal\calendar\DateArgumentWrapper::$minDate does not have native type hint for its value but it should be possible to add it based on @var annotation "\DateTime". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 31 | ERROR | [x] Property \Drupal\calendar\DateArgumentWrapper::$maxDate does not have native type hint for its value but it should be possible to add it based on @var annotation "\DateTime". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 38 | ERROR | [x] Property \Drupal\calendar\DateArgumentWrapper::$position does not have native type hint for its value but it should be possible to add it based on @var annotation "int". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/modules/custom/calendar/src/CalendarEvent.php -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 20 | ERROR | [x] Property \Drupal\calendar\CalendarEvent::$startDate does not have native type hint for its value but it should be possible to add it based on @var annotation "\DateTime". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 27 | ERROR | [x] Property \Drupal\calendar\CalendarEvent::$endDate does not have native type hint for its value but it should be possible to add it based on @var annotation "\DateTime". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) 44 | ERROR | [x] Property \Drupal\calendar\CalendarEvent::$timezone does not have native type hint for its value but it should be possible to add it based on @var annotation "\DateTimeZone". | | (SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint) -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- Time: 1.02 secs; Memory: 18MB PHP CODE SNIFFER REPORT SUMMARY --------------------------------------------------------------------------------------------------------------------------- FILE ERRORS WARNINGS --------------------------------------------------------------------------------------------------------------------------- /var/www/html/web/modules/custom/calendar/calendar_datetime/src/Plugin/views/argument_default/Date.php 1 0 /var/www/html/web/modules/custom/calendar/src/CalendarDateInfo.php 13 0 /var/www/html/web/modules/custom/calendar/src/CalendarEvent.php 3 0 /var/www/html/web/modules/custom/calendar/src/CalendarStyleInfo.php 15 0 /var/www/html/web/modules/custom/calendar/src/DateArgumentWrapper.php 4 0 /var/www/html/web/modules/custom/calendar/src/Plugin/views/argument_validator/CalendarValidator.php 2 0 /var/www/html/web/modules/custom/calendar/src/Plugin/views/pager/CalendarPager.php 1 0 /var/www/html/web/modules/custom/calendar/src/Plugin/views/style/Calendar.php 5 0 /var/www/html/web/modules/custom/calendar/src/Plugin/ViewsTemplateBuilder/ViewsFieldTemplate.php 1 0 --------------------------------------------------------------------------------------------------------------------------- A TOTAL OF 45 ERRORS AND 0 WARNINGS WERE FOUND IN 9 FILES --------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX 45 OF THESE SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------- PHP CODE SNIFFER VIOLATION SOURCE SUMMARY ---------------------------------------------------------------------------------- SOURCE COUNT ---------------------------------------------------------------------------------- [x] SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint 45 ---------------------------------------------------------------------------------- A TOTAL OF 45 SNIFF VIOLATIONS WERE FOUND IN 1 SOURCE ---------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SOURCES AUTOMATICALLY (45 VIOLATIONS IN TOTAL) ----------------------------------------------------------------------------------

Issue created by @joelpittet
Merge request !57quick phpcbf fixes, likely break things → (Merged) created by joelpittet
Comment 16 days ago →
🇨🇦Canada joelpittet Vancouver
Comment 16 days ago →
System Message

joelpittet → committed 6c8ac3f4 on 8.x-1.x
Issue #3521287 by joelpittet: PHP CS fixes, PHP 8+ type hint and...
Merge request !59Resolve #3521287 "Remove use statement" → (Merged) created by joelpittet
Comment 13 days ago →
System Message

joelpittet → committed 3e96cffc on 8.x-1.x
Resolve #3521287 "Remove use statement"

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!59PHP CS fixes
Merged

!57PHP CS fixes
Merged

Comments & Activities