[PP-1] Evaluate storing XB field type's "deps_*" columns in separate table

wim leers → credited catch → .

wim leers → credited larowlan → .

I can knock up a proof of concept for this if you like

📌 Calculate field and component dependencies on save and store them in an easy to retrieve format Active is in.

@larowlan: I'd love to take you up on your offer! 😄😇

POC in draft MR
Need to move ComponentAuditTest to a Kernel test, mocking database calls is the trigger to move it from a Unit test

FieldTypeUninstallValidatorTest and ComponentAuditControllerTest are passing with this stored for querying.

🥳🤓

New title as we want to proceed with this.

Here's the explain for selecting all entities using e.g. a particular component. We use the same buildDependencyQuery code path for the uninstall validator so the query is the same with only the params changed.

+--+-----------+------------+----------+----+--------------------------------+----------+-------+-----------+----+--------+-----------+
|id|select_type|table       |partitions|type|possible_keys                   |key       |key_len|ref        |rows|filtered|Extra      |
+--+-----------+------------+----------+----+--------------------------------+----------+-------+-----------+----+--------+-----------+
|1 |SIMPLE     |dependencies|null      |ref |PRIMARY,source_entity,dependency|dependency|267    |const,const|1   |100     |Using index|
+--+-----------+------------+----------+----+--------------------------------+----------+-------+-----------+----+--------+-----------+

This is ready for review now

This looks great!

Scariest/hardest to review were
ComponentTreeDependencyRepository and ComponentTreeDependencyRepositoryTest.

But that test is … impressively leading by example 🤩 I think @catch will be quite happy with #12 😄 My literally only question is Why not use a MERGE query?. Not worth holding this big leap forward up for though.

Plus, it puts is in a much better place to do 📌 Allow XB to be used on all node types Active later already 🎉

The only failure here is unrelated to this MR: it's due to 11.1.7 being used on GitLab CI by default now, and that's being fixed over at 🐛 JavaScriptComponentValidationTest::testInvalidSlotIdentifiedByConfigSchema fails Active .

None, except … a measurably faster UI, and hence perhaps live usage counts at /admin/appearance/component?

Implemented:

… which now definitely means we'll need to do 📌 [later phase] Make Component `audit` operation scalable Postponed — but that's intentional 😊