- Issue created by @lauriii
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Next time, please include the request body too, not just the response. 🙏 Saves some reproducing steps.
First step: updating the
it('Can create and add section', () => {
test incomponent-operations.cy.js
to reproduce this bug. 🙏 - 🇫🇮Finland lauriii Finland
Will do, that's easy for me to do! I just didn't realize it would be helpful 😊
- 🇫🇷France anavarre 🇪🇺
This might just be what I ran into today with alpha6 when trying to click on any "Container" section.
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
This one is tricky.
I've expanded the cypress test to the exact steps and it doesn't fail.
I've manually tested and in some cases it occurs and others it doesn't.
So this points to a race condition.On the backend the 'type' is the pattern name and not the component name.
Digging further, I suspect perhaps an optimistic update might be the issue here. - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Ah the reproduction requires drag and drop not click to add, will see if I can reproduce that in a test
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
I wrote a test here for adding a single component but then after realising the issue was with drag and drop, tried to rewrite it to work with drag and drop.
We have no tests that drag and drop from the library to the canvas/viewport/preview so I time-boxed this.
After an hour I had no joy getting this working and decided this isn't something we're going to be able to test with our current Cypruss setupLooks like playwright has baked in support so _maybe_ when we get there? https://playwright.dev/docs/input#drag-and-drop
So the MR is fix only now - as this is critical and the lack of drag and drop from library tests is pre-existing I figure that's ok
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Tagging for playwright follow-up if we get there
- First commit to issue fork.
-
jessebaker →
committed f0415535 on 0.x authored by
larowlan →
Issue #3521078 by larowlan, lauriii: Adding sections to a page broken
-
jessebaker →
committed f0415535 on 0.x authored by
larowlan →
- 🇬🇧United Kingdom jessebaker
Whoops, this was my bad, I totally missed out the section functionality when implementing the new overlay with Dnd kit
Automatically closed - issue fixed for 2 weeks with no activity.