- Issue created by @jessebaker
- @jessebaker opened merge request.
- First commit to issue fork.
- πΊπΈUnited States bnjmnm Ann Arbor, MI
Small request in the MR - but basically this looks good.
- πΊπΈUnited States bnjmnm Ann Arbor, MI
Feedback addressed in a way better than I could have hoped for
-
bnjmnm β
committed 4b34bbaa on 0.x authored by
jessebaker β
Issue #3521034 by jessebaker, bnjmnm: Dragging a Code Component doesn't...
-
bnjmnm β
committed 4b34bbaa on 0.x authored by
jessebaker β
Upon verification, it was observed that none of the components including SDCs and Code Components are exhibiting the fade effect during drag interactions. This seems to be a regression affecting all components, not just the JS Code Components.
- π¬π§United Kingdom jessebaker
From your video @mayur-sose it looks like you are slightly misunderstanding which behaviour needs testing.
The expected behaviour is as follows:
When dragging a component the is already on the layout the component that you start to drag should fade out to indicate which one you have "picked up". The fade out is based on which component started the drag operation, not which component your mouse is over as you are dragging.Prior to this fix, the behaviour above only happened for SDC components, not Code Components. It should now happen no matter the component source.
By contrast, in your video you are dragging a new component from the library and then moving the mouse over a component in the preview. There is no expectation that the component in the preview will fade out in that scenario so this is not a regression.
- When a component that is already placed on the canvas is dragged, it properly fades out during the drag operation.
- This fade effect triggers correctly upon starting the drag and remains until the drag is completed or canceled.
- Dragging a new component from the library onto the canvas does not cause any fade-out of components on the canvas.
- This is the intended behavior and works correctly.
- Both SDC and Code Components exhibit the same fade-out behavior, ensuring consistency across component types.