- Issue created by @apmsooner
- πΊπΈUnited States apmsooner
Alot of refactoring and cleanup but I think its working really solid now and needs some user testing.
- πΊπΈUnited States jrockowitz Brooklyn, NY
I had a few minutes to test this patch.
Below are my basic steps to review
- Check out the MR
- Clear cache
- Add custom field to page content type
- Create a link field using default values
- Create a link field that only shows URL, placeholder, attributes, etc...
- Confirmed default link field worked as expected
- Confirmed customize link field worked as expected
The most immediate minor issue I found was adding a new link field logged the below warning multiple times.
Deprecated function: Creation of dynamic property Drupal\custom_field\Plugin\DataType\CustomFieldLink::$value is deprecated in Drupal\Core\TypedData\TypedData->setValue() (line 102 of core/lib/Drupal/Core/TypedData/TypedData.php).
- πΊπΈUnited States apmsooner
Thanks for the review Jake! I just pushed a commit that should fix the deprecation warning.
- πΊπΈUnited States apmsooner
Everything is checking out on this feature and working properly so calling it good.
-
apmsooner β
committed 2f11573f on 3.1.x
Issue #3520895 by apmsooner, jrockowitz: Link field type
-
apmsooner β
committed 2f11573f on 3.1.x
Automatically closed - issue fixed for 2 weeks with no activity.