- Issue created by @mondrake
- 🇮🇹Italy mondrake 🇮🇹
Huh, harder than I thought. This is adding future additional interface parameters, since it seems that they are just missing currently.
- 🇮🇹Italy mondrake 🇮🇹
Future changes, yes, following the process:
https://www.drupal.org/node/3376455 →
https://www.drupal.org/about/core/policies/core-change-policies/how-to-d... → - 🇺🇸United States smustgrave
I know we were looking to close that meta but guess it’s been used another round.
Going to comment there I suggest closing the meta in 12
Chances here seem fine then
Though without a dedicated CR may be a surprise to some when the parameter just appears
- 🇮🇹Italy mondrake 🇮🇹
Agree we should close that meta issue, made changes there accordingly.
wrt to the CR, I am unsure. tbh I find the as-is a bit weird, many implementations of the interface methods rely on those params that are not in the interface signature - to the point that I was confused, started trying to remove them in the implementations just to realize afterwards I should do the other way around i.e. adding them to the interfaces. So for me we are just getting things right as they should be here, not changing conceptually the API. My 0.02€.
The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.