Messages in \Drupal\experience_builder\Controller\ErrorCodesEnum are not helpful

Working on it

I've updated the messages in \Drupal\experience_builder\Controller\ErrorCodesEnum::getMessage() to make them more helpful and actionable.

@tedbow: can you propose improved UI strings? 🙏

@lauriii since you made this issue did you run into these messages while using XB or just reviewing?

If you ran into it using XB what circumstances where they under? Locally where there was only one person using XB or where there might have been more?

I ran into this by making a change and then quickly trying to publish it after making that change. I think the error I got was "This item is unexpected." and it was really confusing because I had no idea what is "this" in the context of the message and why it was unexpected.

@lauriii thanks. Yeah that is the case that I could reproduce manually but not all the time.

Created 🐛 Click publish shortly after making a change can lead to error Active as idea how we might make this situation in #9 less likely

Clarifying issue title; issue summary could still use an update. Per @tedbow, 🐛 Click publish shortly after making a change can lead to error Active probably is the right thing to do here, because that reduces the probability of ever seeing these messages.

Updated the error messages in ErrorCodesEnum::getMessage() as per feedback from @tedbow.

Per #13.

think is good. Thanks @meghasharma. Hopefully e2e test will pass otherwise because it is component-operations.cy.js is probably random fail

This is still marked as "Needs design" but I think it would be ok to merge the existing MR and then improve. The updated message would at least give the user something they can do that I think should resolve the problem. We can then improve

This definitely seems like an improvement over what was there before 👍

Ok. Let's get this and then figure how we can make it better

Going to mark as fixed as 🐛 Click publish shortly after making a change can lead to error Active should make it better.

If we still want to improve the messaging further, lets just reopen this issue