- Issue created by @svendecabooter
- First commit to issue fork.
- 🇧🇪Belgium RandalV
@svendecabooter the changes have been applied in the MR.
Feel free to check it out, everything seems to work fine.Changed minimum Drupal Core version to 10.1, PHP remains at >= 8.1.
- 🇧🇪Belgium RandalV
Processed the feedback.
I was also debating whether the Help and Cron hooks could be merged into a "Core.php" file since they're both small hooks, but I just kept them in their own file.
Figured it's better to keep things as split up as possible, which is the whole point of moving away from one gigantic .module file to OOP hooks :) - 🇧🇪Belgium svendecabooter Gent
Seems like core is mostly putting all hooks together in a Hook\[MODULENAME]Hooks.php file, but I agree splitting up in logical chunks / files makes sense.
- 🇧🇪Belgium svendecabooter Gent
MR looks good to me.
Maybe we also need to add the 'hooks_converted' parameter for performance improvement: https://www.drupal.org/node/3490771 → - 🇧🇪Belgium RandalV
Seems logical, I've added the hooks_converted parameter.
Since the other threads are resolved, I'll merge into 1.2.x
Automatically closed - issue fixed for 2 weeks with no activity.