Contrib.social

Stricter PHP quality tests in GitLab CI

Open on Drupal.org →
Created on 18 April 2025, 7 days ago

Problem/Motivation

Currently GitLab CI carries out code quality tests, but they are not required to pass.

Also, phpstan runs at the default level "1". We can do better!

Steps to reproduce

Make a change that causes phpcs or phpstan tests to fail. GitLab CI will report a warning, but will not stop build passing.

Proposed resolution

Set allow_failure to false for phpcs and phpstan.

Also add a phpstan.neon file to specify the phpstan level.

Remaining tasks

Add allow_failure variables to .gitlab-ci.yml
Create phpstan.neon file specifying level 5

User interface changes

N/A

API changes

N/A

Data model changes

N/A

📌 Task
Status

Active

Version

1.0

Component

Code

Created by

🇧🇪Belgium tim-diels Belgium 🇧🇪

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024