- Issue created by @mondrake
- ๐ฎ๐นItaly mondrake ๐ฎ๐น
mondrake โ changed the visibility of the branch 3519804-dummymimetypemaploadedsubscriber-does-not to hidden.
- ๐ฎ๐นItaly mondrake ๐ฎ๐น
mondrake โ changed the visibility of the branch 3519804-dummymimetypemaploadedsubscriber-does-not to active.
- ๐ฎ๐นItaly mondrake ๐ฎ๐น
The test-only job does not seem to work - maybe because the change is only of the service yml file?
- ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
I think we can use autoconfiguration here and I have confirmed that the test finds the problem. Nice spot.
- ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
Reviewed the code changes and agree with moving legacy tests. Unfortunately a test-only run doesn't not fail to confirm the bug is fixed as the code that would fail has been moved to a new test class. Not sure if it's worth it pursuing?
- ๐ฎ๐นItaly mondrake ๐ฎ๐น
I think #7 stands for test failure confirmation? Test-only does not fail because afaics the yaml service file change does not get reverted.
- ๐ฎ๐นItaly mondrake ๐ฎ๐น
This is blocking ๐ SophronMimeTypeMapFactory should just override MimeTypeMapFactory::doCreateMap() Active .
- ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
Based on #10 I think we can RTBC this now.
-
alexpott โ
committed 7da6cdbf on 11.x
Issue #3519804 by mondrake, kim.pepper, alexpott:...
-
alexpott โ
committed 7da6cdbf on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.