- Issue created by @codebymikey
Not all installations have ffmpeg and ffprobe located in /usr/local/bin/ffmpeg
and /usr/local/bin/ffprobe
.
There's logic within the library to auto-detect the default binary path, so I think it should be the default behaviour for the most compatibility.
On a new installation on Ubuntu, the binary might be installed in /usr/bin/
Two options:
* Update the default config installs to just ffmpeg
and ffprobe
, and let it autodetect the default location.
* Keep it empty, and pass NULL
to the library if it's empty so it uses its own internal logic to detect the default binary locations.
Provide issue fork/patch, with logic along the lines of this to allow the default binaries to be used.
--- media_thumbnails_video.module
+++ media_thumbnails_video.module
@@ -84,10 +84,10 @@
try {
// Create ffmpeg container.
$ffmpeg = FFMpeg::create([
- 'ffmpeg.binaries' => $config->get('ffmpeg'),
- 'ffprobe.binaries' => $config->get('ffprobe'),
+ 'ffmpeg.binaries' => $config->get('ffmpeg') ?: NULL,
+ 'ffprobe.binaries' => $config->get('ffprobe') ?: NULL,
'timeout' => $config->get('timeout'),
'ffmpeg.threads' => $config->get('threads'),
]);
N/A
Active
2.0
Code