- Issue created by @yoerioptr
- ๐ฎ๐ณIndia Ishani Patel
ishani patel โ made their first commit to this issueโs fork.
- Merge request !6Issue #3519481: trim(): Passing null to parameter #1 ($string) of type string is deprecated โ (Open) created by Unnamed author
- ๐ฎ๐ณIndia Ishani Patel
I've created MR,
Please check and review.Thank you!
- ๐ฉ๐ชGermany D34dMan Hamburg
@yoerioptr,
Thanks for the Bug Report. Is it possible to share the configuration so that I can understand how view width can be empty? I suspect this could be an issue where view width configuration is not validated properly before save.
@ishani patel, thanks for the MR. However, this seems to be a result from invalid configurations and can cause much more severe issues if we let it fail silently. So an alternate fix needs to be explored.
- ๐ง๐ชBelgium yoerioptr
Thanks for the reply. After re-configuring I didn't encounter any issues. Maybe I did something wrong on my side. It might also be good to add extra validation to the configuration form. For example, if a breakpoint is enabled, make the width and aspect ratio a requirement. This might prevent similar issues.