- Issue created by @BenStallings
- 🇦🇺Australia acbramley
There's many out of scope changes here going from constructor injection to setting class props in ::create. All of that needs to be reverted.
PHPstan reports:
------ ------------------------------------------------------------------------------
Line src/Controller/NodeRevisionController.php
------ ------------------------------------------------------------------------------
59 \Drupal calls should be avoided in classes, use dependency injection instead
------ ------------------------------------------------------------------------------------ ------------------------------------------------------------------------------
Line src/DiffEntityParser.php
------ ------------------------------------------------------------------------------
46 \Drupal calls should be avoided in classes, use dependency injection instead
------ ------------------------------------------------------------------------------------ ---------------------------------------------------------------------------------
Line src/DiffLayoutBase.php
------ ---------------------------------------------------------------------------------
142 \Drupal calls should be avoided in classes, use dependency injection instead
254 Method Drupal\diff\DiffLayoutBase::buildConfigurationForm() should return array
but return statement is missing.
------ --------------------------------------------------------------------------------------- ------------------------------------------------------------------------------
Line src/Plugin/views/field/DiffFrom.php
------ ------------------------------------------------------------------------------
78 \Drupal calls should be avoided in classes, use dependency injection instead
------ ------------------------------------------------------------------------------
phpstan -l0 diff
$instance = parent::create() pattern.make a merge request.
Active
2.0
Code
There's many out of scope changes here going from constructor injection to setting class props in ::create. All of that needs to be reverted.