Convert field template_preprocess functions in theme.inc

Created on 15 April 2025, 2 months ago

Problem/Motivation

See πŸ“Œ [pp-1] Convert Template Preprocess hooks to OOP equivalent Postponed: needs info

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Needs review

Version

11.0 πŸ”₯

Component

theme system

Created by

πŸ‡¨πŸ‡­Switzerland berdir Switzerland

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @berdir
  • Merge request !11834field preprocess β†’ (Closed) created by berdir
  • Pipeline finished with Failed
    2 months ago
    Total: 91s
    #473882
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Appears to have a pipeline issue.

    Could the issue summary be updated with what is being deprecated exactly. Probably need a new CR as the one it's referencing is already out.

  • Pipeline finished with Failed
    2 months ago
    Total: 4348s
    #474320
  • πŸ‡ΊπŸ‡ΈUnited States nicxvan

    Yes, this needs a rebase, the other issue has the same failure.

  • Pipeline finished with Success
    2 months ago
    #479126
  • πŸ‡¨πŸ‡­Switzerland berdir Switzerland

    Rebased, MR is green.

  • The Needs Review Queue Bot β†’ tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

    This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

    Consult the Drupal Contributor Guide β†’ to find step-by-step guides for working with issues.

  • Pipeline finished with Success
    about 2 months ago
    #491182
  • πŸ‡¨πŸ‡­Switzerland berdir Switzerland

    Rebased

  • Pipeline finished with Success
    about 1 month ago
    Total: 524s
    #495218
  • πŸ‡ΊπŸ‡ΈUnited States nicxvan

    These are very tedious to review and it's hard to show the effort since you do such a good job!

    I confirmed the conversions were accurate.
    I confirmed you inlined the one helper function.

    Just asked one clarifying question but it's not a blocker.

    • catch β†’ committed b772cdc5 on 11.x
      Issue #3519259 by berdir, nicxvan: Convert field template_preprocess...
  • Status changed to Fixed 5 days ago
  • πŸ‡¬πŸ‡§United Kingdom catch

    I asked about the deprecation of the preprocess function itself in slack and @berdir explained that (unlike most procedural hooks) there is a reasonable amount of contrib calls to various preprocess functions, usually from other preprocess functions.

    Couldn't see anything else wrong here and agreed on not trying to add a helper for the sorting.

    Don't think we need a CR for the deprecations because this is all internal code anyway. Updated the deprecated in version from 11.2.0 to 11.3.0 on commit.

    Committed/pushed to 11.x, thanks!

Production build 0.71.5 2024