- Issue created by @berdir
- 🇺🇸United States smustgrave
Appears to have a pipeline issue.
Could the issue summary be updated with what is being deprecated exactly. Probably need a new CR as the one it's referencing is already out.
- 🇺🇸United States nicxvan
Yes, this needs a rebase, the other issue has the same failure.
The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇺🇸United States nicxvan
These are very tedious to review and it's hard to show the effort since you do such a good job!
I confirmed the conversions were accurate.
I confirmed you inlined the one helper function.Just asked one clarifying question but it's not a blocker.