Convert template_preprocess_pager()

Created on 15 April 2025, 28 days ago

Problem/Motivation

See πŸ“Œ [pp-1] Convert Template Preprocess hooks to OOP equivalent Postponed: needs info

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Needs review

Version

11.0 πŸ”₯

Component

theme system

Created by

πŸ‡¨πŸ‡­Switzerland berdir Switzerland

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @berdir
  • Merge request !11833pager preprocess β†’ (Open) created by berdir
  • Pipeline finished with Failed
    28 days ago
    Total: 116s
    #473881
  • πŸ‡¨πŸ‡­Switzerland berdir Switzerland
  • Pipeline finished with Failed
    28 days ago
    Total: 195s
    #473884
  • Pipeline finished with Canceled
    27 days ago
    Total: 105s
    #474318
  • Pipeline finished with Failed
    27 days ago
    Total: 4415s
    #474319
  • πŸ‡ΊπŸ‡ΈUnited States nicxvan

    Quick comment on the constructor.

    Any reason behind the file and function names being inverted?

  • πŸ‡¨πŸ‡­Switzerland berdir Switzerland

    > Any reason behind the file and function names being inverted?

    I assume you mean classname?

    It's the same with all the Preprocess classes that I added. Class is FooPreprocess, and then the methods are preprocessFoo. with ThemeProcess it was just so that Foo wasn't the same thing so far.

    Makes sense to me, for the class name it's just following naming rules (repeat last part of namespace if otherwise not providing enough context/being unique enough), while methods are verbThing.

  • πŸ‡ΊπŸ‡ΈUnited States nicxvan

    Yes, this needs a rebase, the other issue has the same failure.

  • Pipeline finished with Success
    21 days ago
    #479124
  • πŸ‡¨πŸ‡­Switzerland berdir Switzerland

    Rebased.

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Taking a guess here.

    But applied the MR, setup a paginated view,
    Pagination appears to be working.

    The one thread about brackets probably can be a coding standard issue as sure there are other instances that may need to be fixed.

  • πŸ‡ΊπŸ‡ΈUnited States nicxvan

    Yeah I also carefully reviewed this, both with and without the zebra command git diff 11.x --color-moved=dimmed_zebra --color-moved-ws=ignore-all-space

    The changes are comments and injections.

    I retract my comments on the MR as @smustgrave and @berdir pointed out they belong in a coding standards issue.

  • The Needs Review Queue Bot β†’ tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

    This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

    Consult the Drupal Contributor Guide β†’ to find step-by-step guides for working with issues.

Production build 0.71.5 2024