Contrib.social

Dialogs opened by CKEditor5 need to be rendered with admin theme

Open on Drupal.org →
Created on 14 April 2025, 2 months ago

Not worth starting until 📌 CKeditor not loading on formatted text fields in the content entity + component instance forms Active lands, since CKEditor 5 won't work until that is in.

Overview

Media library and other dialogs triggered by CKEditor 5 need to match the behavior of media library widgets opened in the Page Data / Component Instance forms. Without this, the appearance is unpredictable and some form fields might not work. Plus, it risks adding non-fenced admin theme styles to the XB UI due to the libraries added via the AJAX request

Proposed resolution

User interface changes

📌 Task
Status

Postponed

Version

0.0

Component

Page builder

Created by

🇺🇸United States bnjmnm Ann Arbor, MI

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @bnjmnm
  • Comment 2 months ago →
    🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
  • Comment 2 months ago →
    🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

    IDK what happened there 😅

  • Comment 2 months ago →
    🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
  • Merge request !925#3519141 Dialogs opened by CKEditor 5 should admin-theme just like the rest → (Merged) created by bnjmnm
  • Pipeline finished with Failed
    2 months ago
    Total: 2093s
    #478683
  • Comment 2 months ago →
    🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
  • Comment 2 months ago →
    🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
  • Pipeline finished with Failed
    2 months ago
    Total: 3266s
    #479571
  • Pipeline finished with Failed
    2 months ago
    Total: 1774s
    #479618
  • Pipeline finished with Failed
    2 months ago
    Total: 1724s
    #480515
  • Pipeline finished with Failed
    2 months ago
    Total: 1466s
    #480602
  • Pipeline finished with Failed
    2 months ago
    Total: 604s
    #481152
  • Pipeline finished with Failed
    about 2 months ago
    Total: 892s
    #484053
  • Pipeline finished with Failed
    about 2 months ago
    Total: 661s
    #484080
  • Pipeline finished with Failed
    about 2 months ago
    Total: 2161s
    #484153
  • Pipeline finished with Failed
    about 2 months ago
    Total: 2393s
    #484761
  • Pipeline finished with Canceled
    about 2 months ago
    Total: 231s
    #485686
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1560s
    #485692
  • Pipeline finished with Failed
    about 2 months ago
    Total: 626s
    #485737
  • Pipeline finished with Failed
    about 2 months ago
    #485983
  • Pipeline finished with Canceled
    about 2 months ago
    Total: 458s
    #493380
  • Pipeline finished with Failed
    about 2 months ago
    Total: 2858s
    #493386
  • Pipeline finished with Failed
    about 1 month ago
    Total: 2935s
    #495182
  • Pipeline finished with Success
    about 1 month ago
    Total: 1151s
    #495211
  • Pipeline finished with Success
    about 1 month ago
    Total: 1288s
    #495230
  • Comment about 1 month ago →
    🇺🇸United States bnjmnm Ann Arbor, MI
  • First commit to issue fork.
  • Pipeline finished with Failed
    about 1 month ago
    Total: 576s
    #497391
  • Pipeline finished with Failed
    about 1 month ago
    Total: 211s
    #501844
  • Pipeline finished with Failed
    about 1 month ago
    Total: 668s
    #501886
  • Pipeline finished with Success
    about 1 month ago
    Total: 745s
    #501928
  • Pipeline finished with Success
    about 1 month ago
    Total: 3739s
    #502914
  • Comment 21 days ago →
    🇬🇧United Kingdom f.mazeikis Brighton

    Reviewed and tested - seems to work as expected.

  • Pipeline finished with Success
    21 days ago
    Total: 1033s
    #512436
  • Pipeline finished with Skipped
    21 days ago
    #512496
  • Comment 21 days ago →
    System Message
    • bnjmnm → committed fb567856 on 0.x 
      Issue #3519141 by bnjmnm, larowlan: Dialogs opened by CKEditor 5 need to...
  • Comment 21 days ago →
    🇺🇸United States bnjmnm Ann Arbor, MI

    Thx for reviews everyone

  • Status changed to Fixed 7 days ago
  • Comment 7 days ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024