Config overrides are loaded for English even when translate_english is false

Pushed a proof of concept, including 📌 Add database and cache assertions to OpenTelemetryFrontPagePerformanceTest and OpenTelemetryNodePagePerformanceTest Active which makes it easy to see the difference.

To do this properly we'd want to inject the config factory.

    
    Open Telemetry Front Page Performance (Drupal\Tests\demo_umami\FunctionalJavascript\OpenTelemetryFrontPagePerformance)
     ✘ Front page performance
       ┐
       ├ Failed asserting that two arrays are identical.
       ┊ ---·Expected
       ┊ +++·Actual
       ┊ @@ @@
       ┊  Array &0 [
       ┊ -····'QueryCount'·=>·376,
       ┊ -····'CacheGetCount'·=>·471,
       ┊ -····'CacheSetCount'·=>·467,
       ┊ +····'QueryCount'·=>·298,
       ┊ +····'CacheGetCount'·=>·393,
       ┊ +····'CacheSetCount'·=>·389,
       ┊      'CacheDeleteCount' => 0,
       ┊      'CacheTagLookupQueryCount' => 49,
       ┊      'CacheTagInvalidationCount' => 0,

Works.

Tidied up the MR. Still includes 📌 Add database and cache assertions to OpenTelemetryFrontPagePerformanceTest and OpenTelemetryNodePagePerformanceTest Active but that issue is RTBC, so moving to needs review.

https://git.drupalcode.org/project/drupal/-/merge_requests/11822/diffs?c... shows the performance improvement. About 90 database queries and cache gets removed on a cold cache.

That setting is only for interface translation, if your config language is not en you need to load english overrides. But maybe we can check the lang code instead?

hmm good point, so something like check if the config langcode is the same as the default langcode and short-circuit that way?

There's many bugs in config translation and locale so I'm not sure we can guess anything until the flow is settled

IMO the cause here is ✨ Configuration langcode is forced to site default language Needs work

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.