Contrib.social

Variable name $fc_user_settings is confusing

Open on Drupal.org →
Created on 12 April 2025, 5 months ago

Problem/Motivation

Variable $fc_user_settings is mostly set by embedded code. IE:

   $fc_user_settings = [
          'batCalendar' => [
            [
              'background' => 'hide-book',
              'businessHours' => $business_hours,
              'defaultView' => 'timelineDay',
              'eventType' => $event_type,
              'eventGranularity' => $event_granularity,
              'editable' => FALSE,
              'headerLeft' => 'today',
              'headerCenter' => 'title',
              'headerRight' => 'prev, next',
              'selectable' => FALSE,
              'unitType' => $unit_type,
              'unitIds' => implode(',', $units_ids),
              'views' => 'timelineDay',
              'viewsTimelineDaySlotDuration' => '01:00',
            ],
          ],
        ];

while from the name one can understand values come from user preference.

Proposed resolution

Rename variable from $fc_user_settings to $fc_settings

Impact

Applies to more related modules as BEE

🌱 Plan
Status

Needs work

Version

11.1

Component

Code

Created by

🇮🇹Italy afagioli Rome

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024