Test coverage to prove that BlockPluginInterface cacheability + BigPipe support work when rendered via XB

I'll get an initial MR going.

Actually, 🐛 Placeholders/#lazy_builder is not supported for block component rendering Active implies BigPipe support.

Refactored for better consistency.

🏓

📌 Introduce unit test coverage for both ComponentSource plugins (Block + SDC) Active is in, so we should now also update \Drupal\Tests\experience_builder\Kernel\Plugin\ExperienceBuilder\ComponentSource\BlockComponentTest::testRenderComponentLive(), which is really the accurate place to test this, not ComponentTreeHydratedTest.

For #9 — sorry for not failing to set on that one 🙈

Added some more test coverage to BlockComponentTest::testRenderComponentLive(),

Not yet passing tests 😇

Also: did you want to keep or revert your changes to ::renderComponent() wrt #access or not? (As discussed yesterday in person during DDD.)

Moving back to "Needs work" as after rebasing some unit tests are failing.

Looks great!

But \Drupal\Tests\experience_builder\Kernel\Plugin\ExperienceBuilder\ComponentSource\BlockComponentTest::testRenderComponentLive() (unlike what @longwave indicated in #11? 🤔) still has no changes and hence:

'cacheability' => $default_cacheability,

for all of its tested blocks. Let's make \Drupal\xb_test_block\Plugin\Block\XbTestBlockInputNone vary by the user cache context and have it do something like:

diff --git a/tests/modules/xb_test_block/src/Plugin/Block/XbTestBlockInputNone.php b/tests/modules/xb_test_block/src/Plugin/Block/XbTestBlockInputNone.php
index c7a152a19..52a413e00 100644
--- a/tests/modules/xb_test_block/src/Plugin/Block/XbTestBlockInputNone.php
+++ b/tests/modules/xb_test_block/src/Plugin/Block/XbTestBlockInputNone.php
@@ -19,7 +19,7 @@ final class XbTestBlockInputNone extends BlockBase {
    */
   public function build() {
     return [
-      '#markup' => '<div>Hello, XB!</div>',
+      '#markup' => '<div>Hello %user-name, from XB!</div>',
     ];
   }
 

This looks good to me @thoward216 did the test changes @wim leers asked for in #18

phpunit test failure is 🐛 JavaScriptComponentValidationTest::testInvalidSlotIdentifiedByConfigSchema fails Active

retesting e2e tests

wim leers → credited larowlan → .

Thanks! See you in 🐛 Placeholders/#lazy_builder is not supported for block component rendering Active next :D

Automatically closed - issue fixed for 2 weeks with no activity.