PHPStan warnings were fixed in
📌
Fix phpstan warnings
Active
. In field formatters create method was new static() replaced with new self(). If I had to guess, there was warning "Unsafe usage of new static()" reported and this was attempt to fix it. This fix made field formatter classes non extendable, since self resolves to field formatter class and not to the class that extends it.
Use the $instance = parent::create() pattern instead of implementing __construct().
Active
3.0
Video Embed Field (base module)
I implemented proposed solution. The same approach is used in Thumbnail field formatter.
The usage of static doesn't generate PHPStan warnings anymore.
May be we should just switch back to using static instead of the much too restrictive self?