- Issue created by @phenaproxima
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Basically, this only needs a one-liner added to
ConfigExistsConstraintValidator
:$constraint->prefix = TypeResolver::resolveDynamicTypeName($constraint->prefix, $this->context->getObject());
See @phenaproxima's https://git.drupalcode.org/project/experience_builder/-/merge_requests/856 for β¨ Content type templates, part 1: introduce a ContentTemplate config entity which always renders an empty component tree for a particular entity display Active .
- π³π±Netherlands bbrala Netherlands
Will do as i'm focussing on config validation at the moment anyways.
- Merge request !11800feat: make sure ConfigExistsConstraint prefix replaces dynamic type expressions. β (Open) created by bbrala
- π³π±Netherlands bbrala Netherlands
Not sure this was novice with creating the tests tbh.
But lets get this reviewed :)
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
LGTM, but would be 100% certain if we could trigger the test-only CI job (which I am not allowed to trigger).
Thanks, @bbrala!
- π³π±Netherlands bbrala Netherlands
Test only is actually red, lovely.
There was 1 failure: 1) Drupal\KernelTests\Core\Config\ConfigExistsConstraintValidatorTest::testValidation with data set "2" (['system.[%parent.reference].'], 'admin', 'system.menu.admin') Failed asserting that two strings are identical. --- Expected +++ Actual @@ @@ -'The 'system.menu.admin' config does not exist.' +'The 'system.[%parent.reference].admin' config does not exist.' /builds/issue/drupal-3518273/core/tests/Drupal/KernelTests/Core/Config/ConfigExistsConstraintValidatorTest.php:49
We're all good.