- Issue created by @larowlan
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Ran the OO hook rector and then cleaned up coding standards, removed any LegacyHooks - because we don't support less than D11.1.2 and then tried to group the hooks logically.
Ran a few tests locally.
Let's see how this goes w.r.t CI time, reference point for PHPUnit in HEAD is about 18 minutes - https://git.drupalcode.org/project/experience_builder/-/pipelines/466926...
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Looks to have saved about 3 minutes which is not too shabby
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
I defer to @longwave on this β his involvement in core and core having made this conversion dozens of times now makes him better able to call out things that could cause pain.
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Looks to have saved about 3 minutes which is not too shabby
π Bumping priority because this would be nice.
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Running a new pipeline to see how much speed gain remains after π Improve CI pipeline runtime Active .
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
No notable speed difference anymore, although variability is very high.
Test run duration: 2 min 7 sec
I've seen less than that on HEAD, but it really fluctuates between 1:45 and 3:15. I bet this helps make the test runs more consistent :)
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Let's land this now, otherwise this has to keep chasing HEAD.
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
So this MR was built on top of
0.x
as of very recently:d28b6220cdca2cce555060f188c326c9c4bbe267
. What has changed in the handful of days since then?Let's look at all hook implementations:
-
git d d28b6220cdca2cce555060f188c326c9c4bbe267 origin/0.x -- *.module
revealed π Auto-saved Javascript Components CSS changes do not work with CSS aggregation Active needed to be ported into this MR.
-
git d d28b6220cdca2cce555060f188c326c9c4bbe267 origin/0.x -- *.inc
Nothing! π₯³
-
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
All green thanks to π [pending] In progress Active π
-
wim leers β
committed ff3c502c on 0.x authored by
larowlan β
Issue #3517636 by wim leers, larowlan: Move to OO hooks now we require...
-
wim leers β
committed ff3c502c on 0.x authored by
larowlan β