- Issue created by @dydave
- 🇫🇷France dydave
Quick follow-up on this issue:
Starting from level 3, I gradually raised the level and each time fixed all the errors prompted by PHPSTAN, until reaching level 6.
Fixed all validation errors, mostly:
- Updated Doc comment blocks return types.
- Updated Doc comment blocks param types.
- Added inline
@var
types definitions. - Changed 4 lines of code, to add elvis operators and reorder chained calls.
- Caught a wrong variable passed in assert function in a Test class.
Added project'sphpstan.neon
file to raise validation level to 6 and ignore certain error messages.
Very few lines of code with very minor changes were impacted in the merge request.
Since the Tests of the MR all passed 🟢, I went ahead and merged the changes above at #3.
The configuration change was made on Gitlab CI by adding the file: phpstan.neon, forcing rule level to
6
.This should be helpful keeping module's code properly maintained with the evolution of the different Core versions, APIs and PHP versions.
PHPSTAN validation is currently not required to merge.
Marking issue as Fixed for now.
Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.