Open the Affirm modal on the review step when pay and complete is clicked

vmarchuk → made their first commit to this issue’s fork.

vmarchuk → changed the visibility of the branch 3517255-open-the-affirm to hidden.

I had to reroll this to accommodate changes from other merges (attached). When testing, I noticed I'd end up on the payment redirect step (e.g., /checkout/8/payment) instead of the simulated successful return from a redirect to advance my order to the checkout completion page. The payment authorization went through fine and the Payment entity was created, I just didn't end up on checkout complete.

This still appears to be missing return processing that would actually place the order.

Full patch attached with changes to RedirectForm to copy what we do in StripePaymentElement.

I refined this a little bit to only directly place the order on return when the modal is being used; redirected customers will process through normal checkout flow completion. Committed!

rszrama → changed the visibility of the branch 3517255-open-affirm-modal-review-step to hidden.

No clue how to delete the issue fork. I ended up just committing via a patch I finalized locally.

rszrama → closed merge request !21

Automatically closed - issue fixed for 2 weeks with no activity.