- Issue created by @daniel.j
- Merge request !6Issue #3516851: Add custom Twig extension for generating menu data β (Merged) created by daniel.j
- π¬π§United Kingdom darren.fisher
darren.fisher β made their first commit to this issueβs fork.
- π¬π§United Kingdom darren.fisher
This is looking really good. I've updated the README in this branch to document this new functionality and changed the default values in MenuDataExtension.php to match what is in the README.
Next steps:
- I'm going to look at using the lorem ipsum service to generate the menu titles.
- We'll want some tests similar to the other twig functions that cover the functionality provided by this new twig function.
- π¬π§United Kingdom darren.fisher
Added the lorem ipsum service to this. Something I've realised is that the lorem ipsum service assumes you want sentences and add full stops to the end of each generation so I will open a separate issue to deal with this and later implement it here.
- π¬π§United Kingdom daniel.j
I've added `MenuDataExtensionTest` to add coverage for this functionality.
Otherwise, I think that this is ready to go, unless it would be good to add another way to specify the shape / size of the menu data other than just the array shape that is implemented already?
Also, would it be good to include any other keys in the menu array, or is the super basic "title", "URL", "attributes" and "below" good enough?
- π¬π§United Kingdom darren.fisher
This looks good. Going to merge to dev and then fix the pipeline there as it's a bit easier for my workflow. I like the way the arguments work so happy to merge in as is.
- π¬π§United Kingdom darren.fisher
Thanks for testing the MR @priscarabelli!!
-
darren.fisher β
committed 244daa94 on 1.0.x authored by
daniel.j β
Issue #3516851: Add custom Twig extension for generating menu data
-
darren.fisher β
committed 244daa94 on 1.0.x authored by
daniel.j β
- π¬π§United Kingdom darren.fisher
Marking fixed. Will tag a release once the tests are passing on 1.0.x