Contrib.social

Improve the translation and lang in the Klaro config

Open on Drupal.org →
Created on 2 April 2025, 3 months ago

Problem/Motivation

Drupal has a flexible language management, and we may create custom language to better match the context.

In Mandarin, there are more granularity to describe a language with the script style.
For instance, there are zh-hant (Traditional Chinese) and zh-hans (Simplified Chinese) for two types of script style.
In terms of the country, region and dialects, zh-hant can be further divided into zh-hant-tw (Traditional Chinese with terms used in Taiwan) and zh-hant-hk (Traditional Chinese with terms used in Taiwan). zh-hans can be divided into zh-hans-cn and zh-hans-sg, etc.

The existing processDrupalSetting() in the class KlaroHelper process the langcode with a easy way, that explode the text and only get the first part of text before the first hyphen "-" character. When there are two hyphens, it conflicts with the way Klaro JS interprets the langcode. Klaro uses Regex to get the first segment of the langcode only when it has one hyphen, and return any other case as is.

This causes the Klaro unable to find the translation.

It is better to make the code more consistent with the JS and improve the flexibility.

Steps to reproduce

  1. Enable the Klaro module
  2. Create a custom language "zh-hant-tw"
  3. Go to the home page under the language. Ex. example.com/zh-hant-tw
  4. The dialog and modal of the Klaro shows various missing translation: zh-hant-tw/[name of the translation]

Proposed resolution

  1. Use the Regex to map the language, and allow exceptions to be used as is.
  2. Assign 'lang' in the config of Klaro to make sure Klaro loads the translation that the Klaro module provides. $settings['config']['translations'][$langcode] = $translations
🐛 Bug report
Status

Active

Version

3.0

Component

Code

Created by

🇹🇼Taiwan amourow

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024