Gitlab CI: Fix all jobs validation errors

Created on 31 March 2025, 3 days ago

Problem/Motivation

The latest build on Gitlab CI reported validation errors for the following jobs:
https://git.drupalcode.org/project/toolbar_menu/-/pipelines/461326
ESLINT, PHPCS, PHPSTAN and STYLELINT

Steps to reproduce

Run build pipeline at:
https://git.drupalcode.org/project/toolbar_menu/-/pipelines/new

Proposed resolution

Fix all validation errors.

Enforce validation of certain jobs in pipeline builds.

📌 Task
Status

Active

Version

3.0

Component

Code

Created by

🇫🇷France dydave

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @dydave
  • Pipeline finished with Success
    3 days ago
    Total: 145s
    #461946
  • Pipeline finished with Success
    3 days ago
    Total: 140s
    #461949
  • Pipeline finished with Success
    3 days ago
    Total: 334s
    #461951
  • Merge request !7Resolve #3516530 "Gitlab ci fix jobs" → (Merged) created by dydave
    • dydave committed 935009d9 on 3.x
      Issue #3516530 by dydave: Gitlab CI: Fixed all jobs validation errors...
  • 🇫🇷France dydave

    Quick follow-up on this issue:

    Since there were not "too" many issues to fix for each job, I was able to create a single merge request and fix all issues in the same ticket.

    Created merge request MR!7 above at #2 with all the necessary changes to fix all jobs validation errors:
    Fixed the Stylelint, PHPCS and PHPSTAN very quickly, since there were only a single error for each job.

    Fixing ESLint took a bit longer, but using the --fix flag with the eslint command, fixed almost all the issues.
    Remaining issues could be fixed manually without too much trouble.

    Lastly, since all the jobs were passing, the Gitlab CI config was updated to require all of them to pass.

    Since the merge request passed all Tests 🟢, I went ahead and merged the changes above at #3.

    Marking issue as Fixed for now.

    Feel free to let us know if you encounter any issues while using the module or have any questions or concerns on any of the latest code changes, would be glad to reply as soon as possible.
    Thanks in advance for your feedback.

Production build 0.71.5 2024