Custom menu link not correct in layout

Created on 31 March 2025, 6 days ago

Problem/Motivation

There are custom menu links possible that use the <nolink>option in the link.

These are not correctly respected in layout of the menu. They are top aligned I think the css for the contained spans are the culprit:

<li class="btn-animate nav__menu-item nav__menu-item-main nav__menubar-item link-only li-1" role="none">
     <span class="nav__menu-link nav__menu-link-main" role="menuitem" tabindex="-1">        
           <span class="menu__url-title">fΓΌr</span>
     </span>
</li>

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Active

Version

1.0

Component

Code

Created by

πŸ‡¦πŸ‡ΉAustria maxilein

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @maxilein
  • πŸ‡¦πŸ‡ΉAustria maxilein
  • πŸ‡¦πŸ‡ΉAustria maxilein
  • πŸ‡¦πŸ‡ΉAustria maxilein

    if I add

    align-items: center;
    to

    @media (min-width: 62rem) {
    .solo-inner .navigation__responsive {
    display: flex !important;
    flex-wrap: wrap;
    align-items: center;
    }
    }

    it is correctly aligned in the menu.
    But I am not sure this is the right position to add it without breaking anything else ...
    please check...

  • πŸ‡ΊπŸ‡ΈUnited States flashwebcenter Austin TX

    Hello,

    The menu system in Solo has been thoroughly tested and fully respects any custom classes applied to menu links.


    If you're experiencing issues with the menu, it's likely due to a conflict specific to your site’s configuration or custom code. Unfortunately, I'm unable to assist with site-specific conflicts outside the scope of the theme.

    Thank you for your understanding.

    Best wishes,
    Alaa

  • πŸ‡¦πŸ‡ΉAustria maxilein

    Thanks for your feedback.
    I am using latest Drupal CMS and latest solo.dev - both without customization and no extra modules enabled.

    But your screenshots helped a lot to narrow the issue down:
    There is a difference if a menu entry has children or not.
    If it has no child the error occurs.
    Please see screenshots.

  • πŸ‡¦πŸ‡ΉAustria maxilein
  • πŸ‡ΊπŸ‡ΈUnited States flashwebcenter Austin TX

    Hello,

    Thank you for the screenshots and the detailed description.

    The menu is designed to target the immediate children of a LI that contains a button or link. However, when a menu item uses nolink and has no child items, Drupal renders it as a span instead of a link or button.

    I’ve updated the menu logic to account for this scenario. It is pushed to dev feel free to use it.

    Best wishes,
    Alaa

  • πŸ‡¦πŸ‡ΉAustria maxilein

    Thank you. It works beautifully.
    By the way: thank you for your quick responses. And I have rarely seen such a clean and well organized theme like yours!
    it is really impressive.

  • πŸ‡ΊπŸ‡ΈUnited States flashwebcenter Austin TX

    You're very welcome β€” I'm glad to hear it's working beautifully!

    Thank you as well for your kind words. I truly appreciate the feedback, and it means a lot to know the theme's organization and clarity stand out. If you need anything else or have further questions, I'm always happy to help!

Production build 0.71.5 2024