- Issue created by @rhovland
- 🇺🇸United States rhovland Oregon
Feature done. Needs the schema updated and an update hook written to migrate setting "show_overview_link" to "link_display" = "overview"
- 🇮🇳India chhavi.sharma
Hi @rhovland,
You are saying that the feature is done but when I selected stars option in view display and selected shorthand link option.
It is not showing any stars, just a link of all reviews with the reviews count.
So can you please clarify what has been accomplished and what is needed to be done here? - 🇺🇸United States rhovland Oregon
Apologies I had opened this issue to push my code and fell asleep before I finished. I pushed them in the morning. The actual feature this issue is for is done. The only thing remaining to do was the update hook so that existing site configuration is migrated over to the new structure. Also I had not made any changes to the configuration schema file yet which needs to be updated to reflect the changes in configuration.
If the stars aren't displaying then that means the rateit library isn't loading. It's displaying like this on my dev site
- 🇺🇸United States rhovland Oregon
Missed a line of code where $rating_element was being set. Link now properly generates.
Still wouldn't explain your problem of stars not showing up since the old code was still creating the rating element. Think it's probably the javascript library missing.