junit.xml: no matching files in phpunit job artifacts

This happens with _PHPUNIT_CONCURRENT: 1 which runs run-tests.sh
Here is an example

Need to check if there is different behavior with _PHPUNIT_CONCURRENT: 0 which runs phpunit binary.

Happy to touch junit.xml at the beginning of the job.

When running with _PHPUNIT_CONCURRENT: 0 we do get the junit.xml file but no simpletest/phpunit-*.xml files -

junit.xml: found 1 matching artifact files and directories 
WARNING: /builds/project/gitlab_templates_downstream/web/sites/default/files/simpletest/phpunit-*.xml: no matching files. Ensure that the artifact path is relative to the working directory (/builds/project/gitlab_templates_downstream) 

as shown in this log

I think (but I could be wrong) that the definition of the artifacts is fixed and cannot be conditional on an environment variable. Therefore we need to create an empty junit.xml file to avoid the error when using run-tests.sh (concurrent=1) and an empty phpunit-*.xml to avoid the error when running phpunit binary (concurrent=0)

This is now ready for review. The downstream d10-plus pipeline uses a GTD branch which has _PHPUNIT_CONCURRENT: 1 for Max PHP, all the other variants have the default _PHPUNIT_CONCURRENT: 0 so both cases are covered. We get no warnings in the log, and browsing to the empty files didplays it properly. If the file was completely empty we would get a render error as in this earlier job

This all works as expected, but I was wondering if there is scope to simplify the directory structure, because files are being written to both
web/sites/default/files/simpletest and web/sites/simpletest/browser_output. It makes browsing the files more tedious, either online or after downloading, having two output folders. Maybe that is for another issue though? This one solves the problem of removing the warnings in the log.

I'd definitely do the directories simplification in a follow-up.

I was going to RTBC but asked a really small question/suggestion in the MR first.

Applied you suggestion and responded on the MR.

Downstream d10 current with concurrent=0. The log is clean with no warnings and we see that phpunit-ignore.xml is created

Downstream d10 max PHP with concurrent=0. The log is clean with no warnings and we see that junit.xml is created

This is ready for review.

The changes look good, but we are also changing the path of the generated files in here, not just creating empty ones.

Marking it RTBC, but can we change the issue summary with the full proposed resolution?

we are also changing the path of the generated files in here, not just creating empty ones.

That was not the intention, and I may be wrong but don't think we are changing the paths. What specific bit make you think this?

Was it this commit?
https://git.drupalcode.org/project/gitlab_templates/-/merge_requests/341...
This is only changing the echo of the statement, as it was missing the --xml argument that was already in the executed command.

Yup, it's that code there.

I thought we were fixing the path to line up with another automatically generated path. Is that commit not doing that?

Doh!! it's just the "echo" 🙈

Ignore that then please and sorry for the noise.