FunctionalJavascript tests are skipped in test-only change when concurrent=0

When the "test-only changes" job was first added in March 2024, Javacsript tests were run correctly, and not skipped. See the example in comment #47 on #3418831-47: Test-only job → so the error must have been introduced since then.

The cause of the new error is the recent issue 📌 Update PHPUnit jobs to new driver when D11 "current" is W3C-compliant Needs work where we introduced two new variables MINK_DRIVER_ARGS_WEBDRIVER_DEFAULT and MINK_DRIVER_ARGS_WEBDRIVER_LEGACY and set the correct one in a new reference snippet .phpunit-webdriver-variables which is called in the .phpunit-base script:.

The "test-only changes" job correctly extends phpunit, and uses most things from that job, but it has its own script: section. The call to the new .phpunit-webdriver-variables needs to be added here too. It's a one-line fix.

Here's a test showing that the ultimate value of the active variable MINK_DRIVER_ARGS_WEBDRIVER is blank. This is fine for run-tests.sh as it does not use this, but the plain phpunit binary needs this variable.

Great investigation and even greater that the fix will be just one one (yay for reusable snippets).

Here's a test showing that the ultimate value of the active...

I think you forgot to add the link there.

Yes I forgot the link, I have edited the comment now.

Here's a re-run using MR355, the tests are run not skipped (and the variable value is shown)
https://git.drupalcode.org/project/scheduler/-/jobs/5226529

Ready for review. When we work on ✨ Add coverage for test-only changes job Active we can include the javascript test too.

The MR looks good and the tests above show it's working as expected. RTBC.

Merged.