- Issue created by @lostcarpark
- 🇮🇳India nidhi27
Hii,
I have created MR #4 to add this feature. Let me know if any changes are needed.
Thanks!
- 🇮🇪Ireland lostcarpark
Thank you for working on this @nidhi27. I've made some minor suggestions around streamlining the constructor and reducing booilerplate in PHP 8.
- 🇮🇪Ireland lostcarpark
I hadn't expected this to start before !3 merged, so it is impacted by some of the changes in that.
I have rebased to bring those changes in.
I think the check itself should be fine, but the test will need updating.
- 🇮🇪Ireland lostcarpark
I have run the tests locally, and carried out manual testing, and this looks good to me. Moving to RTBC.
- 🇮🇪Ireland lostcarpark
Change merged. Thank you for working on this, @nidhi27 and @keshav patel.