- Issue created by @darren.fisher
- 🇬🇧United Kingdom darren.fisher
For now I've resolved the cspell issues because those were pretty easy to resolve by adding the UK dictionary and fixing a few spelling errors in comments. I've had a stab at fixing the phpunit errors by adding config schemas but these will need reviewing to ensure I've used the correct types. There are many PHPCS errors and one PHPStan error which will need to be resolved. I will come back tomorrow and look with fresh eyes! PHPUnit tests are still failing due to an incompatible schema for the min and max keys in settings. Not sure if that makes any sense to anyone here? Anyway I'll chip away some more tomorrow if I get time!!
- 🇬🇧United Kingdom darren.fisher
Here are the pipelines that are passing and failing:
https://git.drupalcode.org/issue/patreon-3514912/-/pipelines/455612
- 🇬🇧United Kingdom MrDaleSmith
Your fails are all to do with the config schema you've added, which is using string types for integer variables.
TBH the reason I've never added gitlab cl to the project is that the tests don't provide any real coverage: they are boilerplate tests added by drupal console when I used it to create the module template. The only thing being tested is that the front page still loads once the module is enabled. Whilst there is some use to that, I'm not certain it's worth adding the MR until the tests do a little more than that.
I also do not like cspell as a test - tests failing because a dictionary doesn't recognise a word like "patreon" or the module code is written by a British English writer doesn't seem like a useful thing to test. I'm not sure I want the overhead of maintaining the spell check side of things as I see very little benefit from it.
- 🇬🇧United Kingdom MrDaleSmith
OK: there's value in what you've done - and the test fail was my config not yours - so I've committed the non-gitlab related changes you've made and tried to give you credit: dunno if it works when the MR itself hasn't been merged, but we'll see. Thanks for your time.