- Issue created by @larowlan
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
AFAICT this issue queue component is a more precise match?
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
This is most obvious after π Add e2e tests for multi-value textfield widget in page data form Active because if you have added multiple items via ajax, they're missing if you reload the page
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Postponed on π Add e2e tests for multi-value textfield widget in page data form Active
Bumping to critical because there is data loss here.
Updated issue summary.
This can be based on top of π Add e2e tests for multi-value textfield widget in page data form Active if someone wants to work on it in the meantime. - πΊπΈUnited States phenaproxima Massachusetts
Will start this tomorrow based on the very clear suggestions in the issue summary. Thanks @larowlan!
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
If you're debugging, this hunk in FormBuilder is where it should pick up the form cache based on the autosave entry.
- Merge request !977Resolve #3514900 "Pp 1 entityformcontroller should" β (Open) created by phenaproxima
- πΊπΈUnited States phenaproxima Massachusetts
I'm a little puzzled. End-to-end tests are failing because there are several places where they assert that the form build ID has changed. That, apparently, is now inverted by what we're doing here. What's the correct approach here -- do we expect the same form build ID to persist (in which case these assertions need to be changed), or do we expect a new build of the form, populated by data from the auto-save manager?
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
I think what is happening is the converse of what we're fixing in the issue this is blocked on
IE there's a cached programmed form state, which prevents Ajax rebuilding the form
It felt too easy that this would just work π
The changes the other issue make to ensure the form state is programmed even if cached. We will need the controller to ensure the form state is not programmed even if cached
Can pick it up Tues morn my time
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
π€¦I'm overthinking it
We can't set input on post requests as it ignores the submitted values
So we just need to wrap the new changes in a check for GET method on the request
Hopefully that's the sauce