I have some custom crop types on a Media bundle and they are not using file entities. In `media_contextual_crop_field_formatter_entity_update` it tries to clean up old crops and the last part of that makes an assumption that the source field is the entity id in on the crop entity. I believe thats a big assumption.
I have created a Media bundle that the source field is an ID from and external DAMS. We're using Drupals cropping and focal points to define crops, but there is no file in or file entity in Drupal. As such, I'm also using the media id for the crop, rather than the file id. The check `if ($context_delta >= $nb || $source_field_target != $crop->get('entity_id')->getString())` will always fail, since the $source_field_target has nothing to do with any ID in Drupal.
Overall continually deleting and recreating the crop still keeps things functioning, but I'm finding out now is a performance killer. But more of that is really in how crops delete though, not that it is being deleted.
Create a media source and bundle that doesn't use an image field as its source field.
The check is making the assumption that the source field is an image field. So breaking out that part of the if statement and making it more specific would still cover out of the box Drupal Image media, and would then skip things like my case, where that assumption is not correct.
Active
2.0
Code
And I would add, if you are making custom crops, then that module developer should also make sure they are getting cleaned up properly.
Ok, nice catch.
But the point I doesn't understood is how you generate derivatives from the images in the external DAM ?
The derivativ exist in the DAM ? ou it be generated "on the flow" when delivered to client ?