- Issue created by @swirt
- 🇺🇸United States kesmith
@swirt - I'm working on a mockup for the report now, but I noticed in the screenshot I captured in simplytest.me that the filter options don't include an "image title" and a "host entity" to filter by, but the table header of the report includes those two filters. Before I just assume, is that because you can't filter by image title or host entity? Or should I add those two filter options?
- 🇺🇸United States swirt Florida
@kellysmith thank you. Yes I worked initially with the Accessibility team and did a loose round of requirements gathering. I left off filters for host entity and for title mainly because there are less important. It is really easy on a View like this to completely overwhelm by filters for everything. So I was trying to be.a little selective. Keep in mind if any site determined that they needed to be able to search title, they could add the filter themselves later, or if it was important to filter by node VS taxonomy they could also add the filter. If you feel they are important, please call it out and we can add them.
- 🇺🇸United States kesmith
@swirt -
Awesome - thank you! I wanted to make sure I wasn't just missing or assuming something! I'm hoping to have the mockup in the first draft form by Sunday night at the latest. I'll update here when I'm done! Thank you for your response and the clarification! - 🇺🇸United States kesmith
Hey @swirt!
Sorry I didn't get this uploaded on Sunday, but @adriancooke and I are meeting today to go over our drafts. Mine is included in the figma file. Today we'll share our drafts, pick what we like, remove what we don't like, merge the 2 drafts together, and hopefully have something for review by tomorrow or Friday.
Thanks! - 🇺🇸United States kesmith
@adriancooke @swirt
I took a stab at Adrian's ideas with Steve's feedback - made a few personal adjustments to how much information is displayed and filterable, and added some additional guidance and supporting text. Feel free to take a look - I'm not totally sure the "chip" idea (where I list the filters I searched for directly above the results) is possible, but I thought having just a quick view of what I filtered by could be useful to the end user. Quick question for @swirt - will all the data in the table populate even if I don't filter by it? Or does it only populate when no filters/that specific filter is employed? I mocked it up to where that data only appears if it's filtered by it, but I think there is likely a use case for all the data appearing in the table all the time - but I'm sure there's just a "drupal does it this way" answer that I'm just not familiar with yet :D
Figma link - 🇺🇸United States swirt Florida
I'm not totally sure the "chip" idea (where I list the filters I searched for directly above the results) is possible, but I thought having just a quick view of what I filtered by could be useful to the end user.
The chip idea is a nice improvement in general to Views filters, but I don't see a contrib module that does that. (There might be one, I just haven't seen it). Even if there was one I don't think we'd want to include it because it would likely force chips on to all Views, and would be kind of opinionated for this module to add. So that change is pretty far out of scope I think.
will all the data in the table populate even if I don't filter by it? Or does it only populate when no filters/that specific filter is employed?
Views in Drupal usually start fully populated and then filter from there. Having a View start as empty and then populate when filtered would create a couple concerns.
- It would change the nature of the "report" to being acting more like a "search", which would be an anti-pattern.
- How would you ever get a complete / full report if the only way to make it populate is to add at least filter?
- 🇺🇸United States adriancooke
@swirt, @kesmith one question about the report - will it show all alt text even if there are no issues, or will it only report images/alt text where a rule has been triggered? Personally I think the former is better, but I’d been assuming it and wanted to check.
- 🇺🇸United States swirt Florida
It will report every img tag that it can find. The filters should/would allow you to restrict it to only things with errors or warnings.
- 🇺🇸United States kesmith
@swirt, @adriancooke - I had a follow-up question. How do tags that have "null" in them display? Because it has a tag, will it also appear in the report, even though it's considered a decorative image and wouldn't need alt text? Or does the report only display tags with content in them - or is it possible to do something like "if tag = null, do not include"?
- 🇺🇸United States swirt Florida
Good question. Every img tag discoverable within the "content" will show in the report regardless of any alt or title attributes. Usually, true "decorative images" are on templates directly and are not discoverable as content. However, if someone puts a decorative image in the WYSIWYG it will appear in the report.
I think there are a few reasons to have them in the report:
- An audit is not helpful if it lacks the ability to surface all things.
- It could be vital to be able to filter for all "decorative" images so they can be examined to see if an editor was being disingenuous and taking the easy way out by labeling them decorative.
- Yesterdays decorative may need to become tomorrow's content
- alt attributes on a given media image are the same everywhere they are used, so in the original use of the image it might have been decorative, but in a subsequent instance it might have been intended as content.
- 🇺🇸United States adriancooke
@kesmith great question and @swirt’s answer makes sense to me. Good to have everything available. Null alt text should also be checked in context. That’s one way it will be helpful to have the content included in the report. Speaking of which…
Here’s an updated mockup of the report that Kelly and I worked on based on our chat last week. Would be great to get any feedback on this in the coming week and we’ll update as needed. Click to see full-sized version:
Higher resolution version: atv-issue-report-mockup.pdf →